lkml.org 
[lkml]   [2023]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] rxrpc_find_service_conn_rcu: use read_seqbegin() rather than read_seqbegin_or_lock()
Date
Oleg Nesterov <oleg@redhat.com> wrote:

> So do you agree that
>
> - the usage of read_seqbegin_or_lock/need_seqretry in
> this code makes no sense because read_seqlock_excl()
> is not possible

Not exactly. I think it should take a lock on the second pass.

> - this patch doesn't change the current behaviour but
> simplifies the code and makes it more clear

That is true.

David

\
 
 \ /
  Last update: 2023-11-20 14:01    [W:0.194 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site