Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] rxrpc_find_service_conn_rcu: use read_seqbegin() rather than read_seqbegin_or_lock() | Date | Thu, 16 Nov 2023 13:41:46 +0000 |
| |
Oleg Nesterov <oleg@redhat.com> wrote:
> So do you agree that > > - the usage of read_seqbegin_or_lock/need_seqretry in > this code makes no sense because read_seqlock_excl() > is not possible
Not exactly. I think it should take a lock on the second pass.
> - this patch doesn't change the current behaviour but > simplifies the code and makes it more clear
That is true.
David
| |