Messages in this thread | | | From | "Romanowski, Rafal" <> | Subject | RE: [Intel-wired-lan] [PATCH net v2] i40e: Fix adding unsupported cloud filters | Date | Thu, 16 Nov 2023 13:41:56 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Ivan Vecera > Sent: Sunday, November 5, 2023 5:46 PM > To: netdev@vger.kernel.org > Cc: Drewek, Wojciech <wojciech.drewek@intel.com>; intel-wired- > lan@lists.osuosl.org; Brandeburg, Jesse <jesse.brandeburg@intel.com>; linux- > kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; Nguyen, > Anthony L <anthony.l.nguyen@intel.com>; Simon Horman > <horms@kernel.org>; Keller, Jacob E <jacob.e.keller@intel.com>; Jakub Kicinski > <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller > <davem@davemloft.net> > Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix adding unsupported cloud > filters > > If a VF tries to add unsupported cloud filter through virchnl then > i40e_add_del_cloud_filter(_big_buf) returns -ENOTSUPP but this error code is > stored in 'ret' instead of 'aq_ret' that is used as error code sent back to VF. In > this scenario where one of the mentioned functions fails the value of 'aq_ret' > is zero so the VF will incorrectly receive a 'success'. > > Use 'aq_ret' to store return value and remove 'ret' local variable. Additionally > fix the issue when filter allocation fails, in this case no notification is sent back > to the VF. > > Fixes: e284fc280473be ("i40e: Add and delete cloud filter") > Reviewed-by: Simon Horman <horms@kernel.org> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > --- > .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > index 08d7edccfb8ddb..3f99eb19824527 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > @@ -3844,7 +3844,7 @@ static int i40e_vc_add_cloud_filter(struct i40e_vf
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
| |