Messages in this thread | | | Date | Thu, 16 Nov 2023 12:17:41 +0100 | Subject | Re: [PATCH v2 10/12] pinctrl: samsung: add exynosautov920 pinctrl | From | Krzysztof Kozlowski <> |
| |
On 16/11/2023 04:50, Jaewon Kim wrote: > > On 23. 11. 15. 21:42, Krzysztof Kozlowski wrote: >> On 15/11/2023 10:56, Jaewon Kim wrote: >>> ExynosAutov920 GPIO has a different register structure. >>> In the existing Exynos series, EINT control register enumerated after >>> a specific offset (e.g EXYNOS_GPIO_ECON_OFFSET). >>> However, in ExynosAutov920 SoC, the register that controls EINT belongs >>> to each GPIO group, and each GPIO group has 0x1000 align. >>> >>> This is a structure to protect the GPIO group with S2MPU in VM environment, >>> and will only be applied in ExynosAuto series SoCs. >> Checkpatch points some warnings: >> >> CHECK: Alignment should match open parenthesis >> CHECK: Lines should not end with a '(' >> CHECK: Macro argument reuse 'reg' - possible side-effects? > > I don`t know this happens. > > When I did the checkpatch, there were no problems as shown below.
Didn't you miss some arguments? Lime --strict?
Best regards, Krzysztof
| |