Messages in this thread | | | From | Anup Patel <> | Date | Thu, 16 Nov 2023 15:42:15 +0530 | Subject | Re: [PATCH v2 1/1] clocksource/timer-risc: Add riscv_clock_shutdown callback |
| |
On Thu, Nov 16, 2023 at 9:38 AM Joshua Yeong <joshua.yeong@starfivetech.com> wrote: > > Add clocksource detach/shutdown callback to disable RISC-V timer interrupt when > switching out riscv timer as clock source > > Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com>
Typo in patch subject: s/timer-risc/timer-riscv/
Otherwise, it looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards, Anup
> --- > drivers/clocksource/timer-riscv.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c > index 57857c0dfba9..e66dcbd66566 100644 > --- a/drivers/clocksource/timer-riscv.c > +++ b/drivers/clocksource/timer-riscv.c > @@ -61,12 +61,19 @@ static int riscv_clock_next_event(unsigned long delta, > return 0; > } > > +static int riscv_clock_shutdown(struct clock_event_device *evt) > +{ > + riscv_clock_event_stop(); > + return 0; > +} > + > static unsigned int riscv_clock_event_irq; > static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) = { > .name = "riscv_timer_clockevent", > .features = CLOCK_EVT_FEAT_ONESHOT, > .rating = 100, > .set_next_event = riscv_clock_next_event, > + .set_state_shutdown = riscv_clock_shutdown, > }; > > /* > -- > 2.25.1 >
| |