| From | Alexander Potapenko <> | Date | Thu, 16 Nov 2023 10:20:31 +0100 | Subject | Re: [PATCH 20/32] s390: Turn off KMSAN for boot, vdso and purgatory |
| |
On Wed, Nov 15, 2023 at 9:34 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote: > > All other sanitizers are disabled for these components as well. > > Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> Reviewed-by: Alexander Potapenko <glider@google.com> (see a nit below)
> --- > arch/s390/boot/Makefile | 1 + > arch/s390/kernel/vdso32/Makefile | 1 + > arch/s390/kernel/vdso64/Makefile | 1 + > arch/s390/purgatory/Makefile | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/arch/s390/boot/Makefile b/arch/s390/boot/Makefile > index c7c81e5f9218..5a05c927f703 100644 > --- a/arch/s390/boot/Makefile > +++ b/arch/s390/boot/Makefile > @@ -8,6 +8,7 @@ GCOV_PROFILE := n > UBSAN_SANITIZE := n > KASAN_SANITIZE := n > KCSAN_SANITIZE := n > +KMSAN_SANITIZE := n
Nit: I think having even a one-line comment before this block (something similar to https://elixir.bootlin.com/linux/latest/source/arch/x86/boot/Makefile#L12) will make it more clear.
But given that the comment wasn't there before, leaving this up to you.
|