Messages in this thread | | | Date | Mon, 13 Nov 2023 21:07:15 +0100 | Subject | Re: [PATCH v7 1/4] dt-bindings: pwm: Add OpenCores PWM module | From | Krzysztof Kozlowski <> |
| |
On 13/11/2023 10:42, William Qiu wrote: > Will update. >>> + >>> +allOf: >>> + - $ref: pwm.yaml# >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - items: >>> + - enum: >>> + - starfive,jh7100-pwm >>> + - starfive,jh7110-pwm >>> + - const: opencores,pwm >> >> That's a very, very generic compatible. Are you sure, 100% sure, that >> all designs from OpenCores from now till next 100 years will be 100% >> compatible? >> > My description is not accurate enough, this is OpenCores PTC IP, and PWM > is one of those modes, so it might be better to replace compatible with > "opencores, ptc-pwm" > > What do you think?
Sorry, maybe this answers maybe doesn't. What is "PTC"?
Best regards, Krzysztof
| |