Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 9/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi | Date | Mon, 13 Nov 2023 16:10:51 +0200 |
| |
"Luca Weiss" <luca.weiss@fairphone.com> writes:
>> >> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> >> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> >> > > @@ -713,3 +713,7 @@ &venus { >> >> > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; >> >> > > status = "okay"; >> >> > > }; >> >> > > + >> >> > > +&wifi { >> >> > > + status = "okay"; >> >> > qcom,ath11k-calibration-variant? >> >> >> >> What value would I put there for my device? Based on existing usages >> >> (mostly for ath10k) I'd say "Fairphone_5"? >> > >> > I think this is fine. >> >> From style point of view I would prefer lower case and dashes, for >> example "fairphone-5" but I'm just nitpicking, uppercase and underscores >> work fine as well. > > I really don't mind, but I used "Fairphone_5" in v2 now, but I can > change it for v3 if that happens if you wish.
Nah, no need to resend. That's fine.
But in the future please try to CC the ath11k list for patches like this, easier to follow what's happening.
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |