Messages in this thread | | | Date | Mon, 13 Nov 2023 16:18:34 +0300 | Subject | Re: [PATCH 2/2] drm/virtio: Modify RESOURCE_GET_LAYOUT ioctl | From | Dmitry Osipenko <> |
| |
On 11/10/23 10:16, Julia Zhang wrote: > Modify RESOURCE_GET_LAYOUT ioctl to handle the use case that query > correct stride for guest linear resource before it is created. > > Signed-off-by: Julia Zhang <julia.zhang@amd.com> > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 26 ++++++++------ > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 47 ++++++++++++-------------- > drivers/gpu/drm/virtio/virtgpu_vq.c | 35 +++++++++++-------- > include/uapi/drm/virtgpu_drm.h | 6 ++-- > include/uapi/linux/virtio_gpu.h | 8 ++--- > 5 files changed, 66 insertions(+), 56 deletions(-)
1. Please squash this all into a single patch. For upstream kernel it's not acceptable to have subsequent commits modifying previous commits. To commit message add your s-o-b, your co-developed-by tags and a brief comment explaining changes you've done to the original patch.
Signed-off-by: Daniel Stone <daniels@collabora.com> Co-developed-by: Julia Zhang <julia.zhang@amd.com> # query correct stride for guest linear resource before it's created Signed-off-by: Julia Zhang <julia.zhang@amd.com>
2. Make sure that patch passes `scripts/checkpatch.pl`
3. Add link to the commit message for the relevant Mesa MR that makes use of the new ioctl. The MR should be already merged or ready to be merged.
Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/123456
-- Best regards, Dmitry
| |