Messages in this thread | | | Date | Mon, 13 Nov 2023 13:53:12 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case |
| |
On Thu, Nov 02, 2023 at 01:56:08PM +0100, Linus Walleij wrote: > On Thu, Nov 2, 2023 at 1:34 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Nov 02, 2023 at 08:36:11AM +0100, Linus Walleij wrote: > > > > So where does this 1 come from in the end? That's the piece I > > > am missing in this explanation. Somewhere, someone decided > > > to pass 1 to indicate "pull to default resistance". > > > > > > Is it coming from ACPI firmware? > > > > No, it's pure Linux kernel decision. > > gpio_set_bias() is who made that. That's why it needs to be chosen on global > > level. > > Aha I see, that makes sense. > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Pushed to my review and testing queue, thanks!
-- With Best Regards, Andy Shevchenko
| |