lkml.org 
[lkml]   [2023]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RFC 15/22] x86/topology: Switch over to GENERIC_CPU_DEVICES
From
On 11/7/23 20:30, Russell King (Oracle) wrote:
> From: James Morse <james.morse@arm.com>
>
> Now that GENERIC_CPU_DEVICES calls arch_register_cpu(), which can be
> overridden by the arch code, switch over to this to allow common code
> to choose when the register_cpu() call is made.
>
> x86's struct cpus come from struct x86_cpu, which has no other members
> or users. Remove this and use the version defined by common code.
>
> This is an intermediate step to the logic being moved to drivers/acpi,
> where GENERIC_CPU_DEVICES will do the work when booting with acpi=off.
>
> This patch also has the effect of moving the registration of CPUs from
> subsys to driver core initialisation, prior to any initcalls running.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ----
> Changes since RFC:
> * Fixed the second copy of arch_register_cpu() used for non-hotplug
> Changes since RFC v2:
> * Remove duplicate of the weak generic arch_register_cpu(), spotted
> by Jonathan Cameron. Add note about initialisation order change.
> Changes since RFC v3:
> * Adapt to removal of EXPORT_SYMBOL()s
> ---
> arch/x86/Kconfig | 1 +
> arch/x86/include/asm/cpu.h | 4 ----
> arch/x86/kernel/topology.c | 27 ++++-----------------------
> 3 files changed, 5 insertions(+), 27 deletions(-)
>

Reviewed-by: Gavin Shan <gshan@redhat.com>

\
 
 \ /
  Last update: 2023-11-20 13:57    [W:0.373 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site