Messages in this thread | | | Date | Wed, 1 Nov 2023 19:47:55 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v5 4/7] eventfs: Save ownership and mode |
| |
On Thu, 2 Nov 2023 08:43:32 +0900 Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Tue, 31 Oct 2023 18:33:30 -0400 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > > > Now that inodes and dentries are created on the fly, they are also > > reclaimed on memory pressure. Since the ownership and file mode are saved > > in the inode, if they are freed, any changes to the ownership and mode > > will be lost. > > Do we (need to) allow to change the ownership and mode of the eventfs files? > I thought it was fixed on the files in tracefs...
Yes, it's the only way to allow non root users access to the tracing directories.
> > Otherwise, the code itself looks good to me. > > Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> >
Thanks!
-- Steve
| |