Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 1 Nov 2023 21:26:50 +0100 | Subject | Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size |
| |
On Wed, Nov 1, 2023 at 1:35 PM Luiz Angelo Daros de Luca <luizluca@gmail.com> wrote:
> Sorry but I noticed no issues:
Don't be sorry about that, it's good news because now I know where to look, i.e. in the ethernet controller.
> My device is using > https://github.com/luizluca/openwrt/tree/ath79_dsa_prep%2Bdevices . In > summary, kernel 6.1 with openwrt generic patches and the > reset-controller patch I sent net-next recently.
Looking good to me.
> [ 3.888540] realtek-smi switch: found an RTL8366RB switch > [ 3.952366] realtek-smi switch: RTL5937 ver 3 chip found
Same version as mine too.
> [ 3.967086] realtek-smi switch: set MAC: 42:E4:F5:XX:XX:XX
Unrelated: I have seen other DSA switches "inherit" the MAC of the conduit interface (BRCM). I wonder if we could do that too instead of this random MAC number. Usually the conduit interface has a properly configured MAC.
> [ 3.976779] realtek-smi switch: missing child interrupt-controller node > [ 3.983455] realtek-smi switch: no interrupt support > [ 4.158891] realtek-smi switch: no LED for port 5
Are the LEDs working? My device has no LEDs so I have never tested it, despite I coded it. (Also these days we can actually support each LED individually configured from device tree using the LED API, but that would be quite a bit of code, so only some fun for the aspiring developer...)
> Maybe the ag71xx driver is doing something differently.
I'll look at it!
Thanks a lot Luiz, Linus Walleij
| |