Messages in this thread | | | Date | Wed, 1 Nov 2023 13:12:24 -0700 | From | Charlie Jenkins <> | Subject | Re: [PATCH v9 5/5] riscv: Test checksum functions |
| |
On Wed, Nov 01, 2023 at 08:14:07PM +0100, Arnd Bergmann wrote: > On Wed, Nov 1, 2023, at 01:18, Charlie Jenkins wrote: > > Add Kconfig support for riscv specific testing modules. This was created > > to supplement lib/checksum_kunit.c, and add tests for ip_fast_csum and > > csum_ipv6_magic. > > > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com> > > --- > > arch/riscv/Kconfig.debug | 1 + > > arch/riscv/lib/Kconfig.debug | 31 ++++ > > arch/riscv/lib/Makefile | 2 + > > arch/riscv/lib/riscv_checksum_kunit.c | 330 ++++++++++++++++++++++++++++++++++ > > I don't understand this bit, what is special about riscv here > that prevents you from adding it to the common lib/checksum_kunit.c? > > Arnd
Oh, I can add it to the common one. I was hesitant to do that just because it would affect all archs.
- Charlie
| |