Messages in this thread | | | Date | Wed, 1 Nov 2023 18:08:25 +0100 | From | Christian Marangi <> | Subject | Re: [net-next PATCH v2 1/2] net: phy: aquantia: add firmware load support |
| |
On Wed, Nov 01, 2023 at 05:54:50PM +0100, Andrew Lunn wrote: > > There are plenty of firmware around so it can be checked by from what I > > have, it looks like they are word aligned... Ok I will use the > > get_unaligned and add a comment saying that we assume the iram and dram > > section are always word aligned. > > We probably want to know if there is firmware out there which is not > word aligned. So i would probably do phydev_err() and return -EINVAL. >
Do we have API to check this? Or I think I should just check the iram and dram size and see if iram_size % sizeof(u32) is zero and return error otherwise.
-- Ansuel
| |