lkml.org 
[lkml]   [2023]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10] drm/tidss: Drop useless variable init
    Hi Tomi,

    Thank you for the patch.

    On Wed, Nov 01, 2023 at 11:17:40AM +0200, Tomi Valkeinen wrote:
    > No need to initialize the ret to 0 in dispc_softreset().
    >
    > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/gpu/drm/tidss/tidss_dispc.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
    > index 9d9dee7abaef..ad7999434299 100644
    > --- a/drivers/gpu/drm/tidss/tidss_dispc.c
    > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
    > @@ -2705,7 +2705,7 @@ static void dispc_init_errata(struct dispc_device *dispc)
    > static void dispc_softreset(struct dispc_device *dispc)
    > {
    > u32 val;
    > - int ret = 0;
    > + int ret;
    >
    > /* Soft reset */
    > REG_FLD_MOD(dispc, DSS_SYSCONFIG, 1, 1, 1);
    >

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2023-11-01 14:56    [W:8.138 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site