lkml.org 
[lkml]   [2023]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/10] drm/tidss: Use pm_runtime_resume_and_get()
    Hi Tomi,

    Thank you for the patch.

    On Wed, Nov 01, 2023 at 11:17:38AM +0200, Tomi Valkeinen wrote:
    > Use pm_runtime_resume_and_get() instead of pm_runtime_get_sync(), which
    > will handle error situations better. Also fix the return, as there
    > should be no reason for the current complex return.
    >
    > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    But I think we would be better off dropping the two small wrappers.

    > ---
    > drivers/gpu/drm/tidss/tidss_drv.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
    > index 4d063eb9cd0b..f403db11b846 100644
    > --- a/drivers/gpu/drm/tidss/tidss_drv.c
    > +++ b/drivers/gpu/drm/tidss/tidss_drv.c
    > @@ -32,9 +32,9 @@ int tidss_runtime_get(struct tidss_device *tidss)
    >
    > dev_dbg(tidss->dev, "%s\n", __func__);
    >
    > - r = pm_runtime_get_sync(tidss->dev);
    > + r = pm_runtime_resume_and_get(tidss->dev);
    > WARN_ON(r < 0);
    > - return r < 0 ? r : 0;
    > + return r;
    > }
    >
    > void tidss_runtime_put(struct tidss_device *tidss)
    >

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2023-11-01 14:51    [W:4.101 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site