Messages in this thread | | | Date | Wed, 1 Nov 2023 13:36:03 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 1/1] net: stmmac: check CBS input values before configuration |
| |
On Wed, Nov 01, 2023 at 02:19:20PM +0800, Gan Yi Fang wrote: > From: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com> > > Add check for below conditions before proceeding to configuration. > A message will be prompted if the input value is invalid. > > Idleslope minus sendslope should equal speed_div. > Idleslope is always a positive value including zero. > Sendslope is always a negative value including zero. > Hicredit is always a positive value including zero. > Locredit is always a negative value including zero.
Which of these conditional are specific to stmmac, and which are generic to CBS? Anything which is generic to CBS i would expect to be checked at a higher level, rather than in every driver implementing CBS.
Andrew
| |