Messages in this thread | | | From | Paul Durrant <> | Date | Wed, 1 Nov 2023 11:02:16 +0000 | Subject | Re: [PATCH v2] KVM x86/xen: add an override for PVCLOCK_TSC_STABLE_BIT |
| |
On 31/10/2023 22:48, David Woodhouse wrote: > On Tue, 2023-10-31 at 15:39 -0700, Sean Christopherson wrote: >> On Tue, Oct 31, 2023, Paul Durrant wrote: >>> >>> + if (force_tsc_unstable) >>> + guest_hv_clock->flags &= ~PVCLOCK_TSC_STABLE_BIT; >> >> I don't see how this works. This clears the bit in the guest copy, then clobbers >> all of guest_hv_clock with a memcpy(). > > Agreed, that seems wrong. >
It is indeed. Looks like it got moved the wrong side of the memcpy() when I rebased.
Paul
| |