lkml.org 
[lkml]   [2023]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] KVM x86/xen: add an override for PVCLOCK_TSC_STABLE_BIT
On 31/10/2023 22:48, David Woodhouse wrote:
> On Tue, 2023-10-31 at 15:39 -0700, Sean Christopherson wrote:
>> On Tue, Oct 31, 2023, Paul Durrant wrote:
>>>
>>> +       if (force_tsc_unstable)
>>> +               guest_hv_clock->flags &= ~PVCLOCK_TSC_STABLE_BIT;
>>
>> I don't see how this works.  This clears the bit in the guest copy, then clobbers
>> all of guest_hv_clock with a memcpy().
>
> Agreed, that seems wrong.
>

It is indeed. Looks like it got moved the wrong side of the memcpy()
when I rebased.

Paul

\
 
 \ /
  Last update: 2023-11-01 12:03    [W:0.042 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site