lkml.org 
[lkml]   [2023]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v2 14/20] x86/kvm: Make kvm_async_pf_enabled __ro_after_init
    From
    Date
    У чт, 2023-07-20 у 17:30 +0100, Valentin Schneider пише:
    > objtool now warns about it:
    >
    > vmlinux.o: warning: objtool: exc_page_fault+0x2a: Non __ro_after_init static key "kvm_async_pf_enabled" in .noinstr section
    >
    > The key can only be enabled (and not disabled) in the __init function
    > kvm_guest_init(), so mark it as __ro_after_init.
    >
    > Signed-off-by: Valentin Schneider <vschneid@redhat.com>
    > ---
    > arch/x86/kernel/kvm.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
    > index 1cceac5984daa..319460090a836 100644
    > --- a/arch/x86/kernel/kvm.c
    > +++ b/arch/x86/kernel/kvm.c
    > @@ -44,7 +44,7 @@
    > #include <asm/svm.h>
    > #include <asm/e820/api.h>
    >
    > -DEFINE_STATIC_KEY_FALSE(kvm_async_pf_enabled);
    > +DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled);
    >
    > static int kvmapf = 1;
    >
    Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

    Best regards,
    Maxim Levitsky

    \
     
     \ /
      Last update: 2023-10-09 18:42    [W:2.651 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site