lkml.org 
[lkml]   [2023]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH 2/2] tools/virtio: Add hints when module is not installed
Date


> -----Original Message-----
> From: Jason Wang <jasowang@redhat.com>
> Sent: Sunday, October 8, 2023 12:36 PM
> To: Liming Wu <liming.wu@jaguarmicro.com>
> Cc: Michael S . Tsirkin <mst@redhat.com>; kvm@vger.kernel.org;
> virtualization@lists.linux-foundation.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; 398776277@qq.com
> Subject: Re: [PATCH 2/2] tools/virtio: Add hints when module is not installed
>
> On Tue, Sep 26, 2023 at 1:00 PM <liming.wu@jaguarmicro.com> wrote:
> >
> > From: Liming Wu <liming.wu@jaguarmicro.com>
> >
> > Need to insmod vhost_test.ko before run virtio_test.
> > Give some hints to users.
> >
> > Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
> > ---
> > tools/virtio/virtio_test.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> > index 028f54e6854a..ce2c4d93d735 100644
> > --- a/tools/virtio/virtio_test.c
> > +++ b/tools/virtio/virtio_test.c
> > @@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev,
> unsigned long long features)
> > dev->buf = malloc(dev->buf_size);
> > assert(dev->buf);
> > dev->control = open("/dev/vhost-test", O_RDWR);
> > +
> > + if (dev->control < 0)
> > + fprintf(stderr, "Install vhost_test module" \
> > + "(./vhost_test/vhost_test.ko) firstly\n");
>
> There should be many other reasons to fail for open().
>
> Let's use strerror()?
Yes, Thanks for the review.
Please rechecked the code as follow:
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -135,6 +135,11 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
dev->buf = malloc(dev->buf_size);
assert(dev->buf);
dev->control = open("/dev/vhost-test", O_RDWR);
+
+ if (dev->control == NULL)
+ fprintf(stderr,
+ "%s: Check whether vhost_test.ko is installed.\n",
+ strerror(errno));
assert(dev->control >= 0);
r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
assert(r >= 0);
Thanks

\
 
 \ /
  Last update: 2023-10-09 04:45    [W:0.173 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site