Messages in this thread | | | Date | Sun, 8 Oct 2023 06:53:49 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] lib/bitmap: move bitmap allocators for device to linux/device.h |
| |
On Sat, Oct 07, 2023 at 04:35:09PM -0700, Yury Norov wrote: > The allocators are simple wrappers around bitmap_{alloc,free}(). > So move them from bitmap to device sources.
No, they belong in the bitmap.h file, as they are devm_* versions of the same functions in this file. They don't belong in the device.h file.
> Similarly to other device wrappers, turn them to static inlines > and place in header.
Why do these need to be inline functions?
thanks,
greg k-h
| |