lkml.org 
[lkml]   [2023]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx compatible
* H. Nikolaus Schaller <hns@goldelico.com> [231007 06:54]:
> Hi Tony,
>
> > Am 07.10.2023 um 08:44 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > * H. Nikolaus Schaller <hns@goldelico.com> [231004 12:50]:
> >> What about the PVR/SGX driver. This needs a compatible that can distinguish
> >> between the DM3725 and DM3730. The first is w/o SGX and the second one
> >> with. Having all summarized as omap3630 does not allow to load the
> >> PVR/SGX driver based on the board specific compatible entry.
> >>
> >> AFAIR this was the original idea behind
> >>
> >> compatible = "goldelico,gta04", "ti,omap3630", "ti,omap36xx", "ti,omap3";
> >
> > I think we already handle this, see drivers/bus/ti-sysc.c and search for
> > DIS_SGX and similar flags for other accelerators.
>
> Ah, ok. This means that the kernel module isn't loaded if the flags of the chip
> are not available. Then we will indeed have no need to describe such variances
> in the DTS.
>
> > So I think this patch is
> > safe to apply?
>
> Looks so (especially as I only have omap3630 based devices with SGX).

OK applying into omap-for-v6.7/dt then.

Thanks,

Tony

\
 
 \ /
  Last update: 2023-10-07 08:59    [W:1.658 / U:2.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site