Messages in this thread | | | Date | Sat, 7 Oct 2023 08:42:53 -0700 | From | "Paul E. McKenney" <> | Subject | Re: nolibc changes since 6.6-rc1 for linux-next |
| |
On Sat, Oct 07, 2023 at 09:06:30AM +0200, Willy Tarreau wrote: > On Thu, Oct 05, 2023 at 05:01:22PM -0700, Paul E. McKenney wrote: > > On Thu, Oct 05, 2023 at 03:30:52PM -0600, Shuah Khan wrote: > > > On 10/5/23 14:58, Paul E. McKenney wrote: > > > > On Thu, Oct 05, 2023 at 10:28:05PM +0200, Thomas Weißschuh wrote: > > > > > On 2023-10-05 14:15:31-0600, Shuah Khan wrote: > > > > > > Hi Thomas, > > > > > > > > > > > > On 10/5/23 11:00, Thomas Weißschuh wrote: > > > > > > > Hi Shuah, > > > > > > > > > > > > > > I'd like to test the current state of nolibc in linux-next. > > > > > > > Could pull the request below into your nolibc branch? > > > > > > > > > > > > > > I'll do some manual tests this weekend, too. > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Thomas > > > > > > > > > > > > > > > > > > > > > The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: > > > > > > > > > > > > > > Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) > > > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git nolibc/next > > > > > > > > > > > > > > for you to fetch changes up to ab663cc32912914258bc8a2fbd0e753f552ee9d8: > > > > > > > > > > > > > > tools/nolibc: automatically detect necessity to use pselect6 (2023-09-28 09:20:35 +0200) > > > > > > > > > > > > Absolutely. Do you mind tagging and pushing the tag and send > > > > > > pull request with the tag? > > > > > > > > > > Sure, here it is: > > > > > > > > > > > > > > > The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: > > > > > > > > > > Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git nolibc-next.2023.10.05a > > > > > > > > > > for you to fetch changes up to ab663cc32912914258bc8a2fbd0e753f552ee9d8: > > > > > > > > > > tools/nolibc: automatically detect necessity to use pselect6 (2023-09-28 09:20:35 +0200) > > > > > > > > Looks good on my laptop: > > > > > > > > make run: > > > > > > > > 160 test(s): 160 passed, 0 skipped, 0 failed => status: success > > > > > > > > make run-user: > > > > > > > > 160 test(s): 158 passed, 2 skipped, 0 failed => status: warning > > > > > > > > Shuah, I can take nolibc for the upcoming merge window (I believe that > > > > it is my turn to do so), but if you would prefer to take them, that also > > > > works for me. Either way, just let me know. > > > > > > Yes it is your turn. Please go ahead and take them. > > > > Very good, I will merge them in and post them to the relevant email lists. > > > > > I will pull and do testing and update you on how it went. > > > > Looking forward to seeing what you find! > > In the list I'm seeing this one which is a fix for breakage introduced > in 6.6-rc1: > > commit 3c9b7c4a228bf8cca2f92abb65575cdd54065302 (korg-nolibc/fixes, 20230830-nolibc-fixes) > Author: Ammar Faizi <ammarfaizi2@gnuweeb.org> > Date: Wed Aug 30 08:02:23 2023 +0700 > > tools/nolibc: i386: Fix a stack misalign bug on _start > > The ABI mandates that the %esp register must be a multiple of 16 when > executing a 'call' instruction. > ... > > We'll have to send it separately so that it gets into 6.6 soon enough. > And I think the update of the tree location in the MAINTAINERS file > would be deserved as well. > > Paul, Shuah, what's the preferred way for you to get fixes for the current > kernel now ? Do you prefer a PR based on a specific branch or just a patch ?
The easiest for me would be if you rebased your stack on top of this new fix, all still based on v6.6-rc1. I can then pull the new stack, including fix, test it, and submit the fix to Linus in a few days, assuming testing goes well.
Would something else work better for you guys?
Thanx, Paul
| |