Messages in this thread | | | Date | Sat, 7 Oct 2023 17:34:52 +0200 | Subject | Re: [PATCH v6 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900 | From | Krzysztof Kozlowski <> |
| |
On 06/10/2023 18:25, Mehdi Djait wrote: > The Techwell TW9900 is a video decoder supporting multiple input > standards, such as PAL and NTSC, and outputs a BT.656 video > signal. > > It's designed to be low-power, posesses some features such as a > programmable comb-filter, and automatic input standard detection > > Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com> > ---
Thank you for your patch. There is something to discuss/improve.
> +properties: > + compatible: > + const: techwell,tw9900 > + > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: VDD power supply > + > + reset-gpios: > + description: GPIO descriptor for the RESET input pin > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for the decoder output. > + > +additionalProperties: false
This goes after required: block
> + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>;
Use 4 spaces for example indentation.
> + > + tw9900: tw9900@44 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Also, drop unused labels
> + compatible = "techwell,tw9900"; > + reg = <0x44>; > + > + vdd-supply = <&tw9900_supply>; > + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; > + > + port { > + tw9900_out: endpoint { > + remote-endpoint = <&vip_in>; > + }; > + }; > + }; > + };
Best regards, Krzysztof
| |