lkml.org 
[lkml]   [2023]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support
Date
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, October 5, 2023 2:11 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> conor+dt@kernel.org; Simek, Michal <michal.simek@amd.com>;
> linux@armlinux.org.uk; f.fainelli@gmail.com; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; git (AMD-Xilinx) <git@amd.com>; Sarath Babu
> Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>
> Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for
> dmaengine support
>
> On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote:
> > */
> > -static int axienet_open(struct net_device *ndev)
> > +
>
> nit: spurious new line
>
> > +static inline int axienet_init_legacy_dma(struct net_device *ndev)
>
> nit: no need for the inline, it has one caller and isn't on the fast path
Thanks, will fix both in next version.

\
 
 \ /
  Last update: 2023-10-06 20:26    [W:0.073 / U:1.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site