lkml.org 
[lkml]   [2023]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] media: sharp: fix sharp encoding
    Date
    The Sharp protocol[1] encoding has incorrect timings for bit space.

    [1] https://www.sbprojects.net/knowledge/ir/sharp.php

    Reported-by: Joe Ferner <joe.m.ferner@gmail.com>
    Closes: https://sourceforge.net/p/lirc/mailman/message/38604507/
    Signed-off-by: Sean Young <sean@mess.org>
    ---
    drivers/media/rc/ir-sharp-decoder.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/rc/ir-sharp-decoder.c b/drivers/media/rc/ir-sharp-decoder.c
    index 3d8488c39c56..3311099cbd57 100644
    --- a/drivers/media/rc/ir-sharp-decoder.c
    +++ b/drivers/media/rc/ir-sharp-decoder.c
    @@ -15,7 +15,9 @@
    #define SHARP_UNIT 40 /* us */
    #define SHARP_BIT_PULSE (8 * SHARP_UNIT) /* 320us */
    #define SHARP_BIT_0_PERIOD (25 * SHARP_UNIT) /* 1ms (680us space) */
    -#define SHARP_BIT_1_PERIOD (50 * SHARP_UNIT) /* 2ms (1680ms space) */
    +#define SHARP_BIT_1_PERIOD (50 * SHARP_UNIT) /* 2ms (1680us space) */
    +#define SHARP_BIT_0_SPACE (17 * SHARP_UNIT) /* 680us space */
    +#define SHARP_BIT_1_SPACE (42 * SHARP_UNIT) /* 1680us space */
    #define SHARP_ECHO_SPACE (1000 * SHARP_UNIT) /* 40 ms */
    #define SHARP_TRAILER_SPACE (125 * SHARP_UNIT) /* 5 ms (even longer) */

    @@ -168,8 +170,8 @@ static const struct ir_raw_timings_pd ir_sharp_timings = {
    .header_pulse = 0,
    .header_space = 0,
    .bit_pulse = SHARP_BIT_PULSE,
    - .bit_space[0] = SHARP_BIT_0_PERIOD,
    - .bit_space[1] = SHARP_BIT_1_PERIOD,
    + .bit_space[0] = SHARP_BIT_0_SPACE,
    + .bit_space[1] = SHARP_BIT_1_SPACE,
    .trailer_pulse = SHARP_BIT_PULSE,
    .trailer_space = SHARP_ECHO_SPACE,
    .msb_first = 1,
    --
    2.42.0
    \
     
     \ /
      Last update: 2023-10-06 15:28    [W:5.357 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site