Messages in this thread | | | Date | Fri, 6 Oct 2023 14:31:27 +0300 | Subject | Re: [PATCH v5 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver | From | Dmitry Baryshkov <> |
| |
On 04/10/2023 19:26, Kuogee Hsieh wrote: > Currently the dp_display_request_irq() is executed at msm_dp_modeset_init() > which ties irq registering to the DPU device's life cycle, while depending on > resources that are released as the DP device is torn down. Move register DP > driver irq handler to dp_display_probe() to have dp_display_irq_handler() > IRQ tied with DP device. In addition, use platform_get_irq() to retrieve irq > number from platform device directly. > > Changes in v5: > -- reworded commit text as review comments at change #4 > -- tear down component if failed at dp_display_request_irq() > > Changes in v4: > -- delete dp->irq check at dp_display_request_irq() > > Changes in v3: > -- move calling dp_display_irq_handler() to probe > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 32 +++++++++++++------------------- > drivers/gpu/drm/msm/dp/dp_display.h | 1 - > 2 files changed, 13 insertions(+), 20 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |