lkml.org 
[lkml]   [2023]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
On Fri, Oct 06, 2023 at 12:40:33PM +0300, Andy Shevchenko wrote:
> @@ -1119,28 +1099,26 @@ static struct pinctrl_desc chv_pinctrl_desc = {
> static int chv_gpio_get(struct gpio_chip *chip, unsigned int offset)
> {
> struct intel_pinctrl *pctrl = gpiochip_get_data(chip);
> - unsigned long flags;
> u32 ctrl0, cfg;
>
> - raw_spin_lock_irqsave(&chv_lock, flags);
> - ctrl0 = chv_readl(pctrl, offset, CHV_PADCTRL0);
> - raw_spin_unlock_irqrestore(&chv_lock, flags);
> + scoped_guard(raw_spinlock_irqsave, &chv_lock)
> + ctrl0 = chv_readl(pctrl, offset, CHV_PADCTRL0);
>
> cfg = ctrl0 & CHV_PADCTRL0_GPIOCFG_MASK;
> cfg >>= CHV_PADCTRL0_GPIOCFG_SHIFT;
>
> if (cfg == CHV_PADCTRL0_GPIOCFG_GPO)
> return !!(ctrl0 & CHV_PADCTRL0_GPIOTXSTATE);
> +

Unrelated whitespace change.

Otherwise looks good,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

\
 
 \ /
  Last update: 2023-10-06 12:27    [W:0.068 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site