Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 6 Oct 2023 09:48:49 +0200 | Subject | Re: [PATCH] m68k: asm/io.h: mark mmio read addresses as const |
| |
On Mon, Oct 2, 2023 at 9:42 PM Arnd Bergmann <arnd@kernel.org> wrote: > On Mon, Oct 2, 2023, at 15:12, Geert Uytterhoeven wrote: > > On Mon, Sep 25, 2023 at 5:53 PM Arnd Bergmann <arnd@kernel.org> wrote: > >> #define out_8(addr,b) (void)((*(__force volatile u8 *) (unsigned long)(addr)) = (b)) > >> #define out_be16(addr,w) (void)((*(__force volatile u16 *) (unsigned long)(addr)) = (w)) > > > > Shouldn't a similar change be made to rom_in_{8,be16,le16}()? > > Right, these seem to have escaped my regex searches. > > > I can do that while applying... > > Ok, thanks!
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> i.e. will queue in the m68k for-v6.7 branch.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |