Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 5 Oct 2023 18:10:39 +0100 | Subject | Re: [PATCH v13 net-next 23/23] Documentation/tcp: Add TCP-AO documentation | From | Dmitry Safonov <> |
| |
Hi Jonathan,
On 10/4/23 23:56, Jonathan Corbet wrote: > Dmitry Safonov <dima@arista.com> writes: > >> It has Frequently Asked Questions (FAQ) on RFC 5925 - I found it very >> useful answering those before writing the actual code. It provides answers >> to common questions that arise on a quick read of the RFC, as well as how >> they were answered. There's also comparison to TCP-MD5 option, >> evaluation of per-socket vs in-kernel-DB approaches and description of >> uAPI provided. >> >> Hopefully, it will be as useful for reviewing the code as it was for writing. > > It looks like useful information; I just have one request... > >> Cc: Jonathan Corbet <corbet@lwn.net> >> Cc: linux-doc@vger.kernel.org >> Signed-off-by: Dmitry Safonov <dima@arista.com> >> Acked-by: David Ahern <dsahern@kernel.org> [..] >> +1. Introduction >> +=============== >> + >> +.. list-table:: Short and Limited Comparison of TCP-AO and TCP-MD5 >> + >> + * - >> + - TCP-MD5 >> + - TCP-AO >> + * - Supported hashing algorithms >> + - MD5 (cryptographically weak). >> + - Must support HMAC-SHA1 (chosen-prefix attacks) and CMAC-AES-128 >> + (only side-channel attacks). May support any hashing algorithm. > > ...can you please avoid using list-table if possible? It makes the > plain-text version nearly impossible to read.
Sure, I also find it unpleasant to look in plain-text. As long as you don't suggest something else, I'll go with plain table:: for the next version - that seems to look a bit better.
Originally I went with list-table as that seems quite spread over Documentation/, but probably worth avoiding another entry there:
[dima@Mindolluin linux-master]$ git grep -ho '[^ ]*table::' Documentation/ | sort | uniq -c 4 acceptable:: 4 csv-table:: 1 executable:: 594 flat-table:: 133 list-table:: 41 table::
Thanks, Dmitry
| ![\](/images/icornerr.gif) |