lkml.org 
[lkml]   [2023]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq: conservative: Simplify the condition of storing 'down_threshold'
On 12-09-23, 06:09, Liao Chang wrote:
> The governor currently checks if the input new down_threshold is less
> than 100 before storing it. However, the up_threshold field of dbs_data
> structure is also limited to be less than 100, so this check is
> unnecessary and remove it.
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> ---
> drivers/cpufreq/cpufreq_conservative.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
> index b6bd0ff35323..56500b25d77c 100644
> --- a/drivers/cpufreq/cpufreq_conservative.c
> +++ b/drivers/cpufreq/cpufreq_conservative.c
> @@ -187,8 +187,7 @@ static ssize_t down_threshold_store(struct gov_attr_set *attr_set,
> ret = sscanf(buf, "%u", &input);
>
> /* cannot be lower than 1 otherwise freq will not fall */
> - if (ret != 1 || input < 1 || input > 100 ||
> - input >= dbs_data->up_threshold)
> + if (ret != 1 || input < 1 || input >= dbs_data->up_threshold)
> return -EINVAL;
>
> cs_tuners->down_threshold = input;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh

\
 
 \ /
  Last update: 2023-10-05 18:16    [W:0.069 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site