lkml.org 
[lkml]   [2023]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7
From
On 05/10/2023 10:21, Ayush Singh wrote:

>>> + clocks:
>>> + maxItems: 2
>>> +
>>> + clock-names:
>>> + description:
>>> + sclk_hf is the main system (mcu and peripherals) clock
>>> + sclk_lf is low-frequency system clock
>> This does no go here, but to clocks. I wrote how it should be done.
>> Don't ignore the feedback.
> It was suggested to use `clock-names` by Nishanth Menon in the previous
> email, so I thought this was what it meant. I will remove clock-names if
> that's better.

clock-names could stay, but this description belongs to "clocks:" how I
wrote last time.

>>> + items:
>>> + - const: sclk_hf
>>> + - const: sclk_lf
>>> +
>>> + reset-gpios: true
>>
>> No, really, why do you change correct code into incorrect one? Who asked
>> you to drop maxItems?
> I found that many bindings (`display/ilitek,ili9486.yaml`,

Panels are constrained by panel-common.

> `iio/dac/adi,ad5758.yaml`) use this pattern instead of `maxItems` for

This I fixed now.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-10-05 18:16    [W:0.041 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site