lkml.org 
[lkml]   [2023]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [EXTERNAL] Re: [PATCH net-next v3] net: ti: icssg_prueth: add TAPRIO offload support
From
On 05/10/23 02:28, Jakub Kicinski wrote:
> On Thu, 28 Sep 2023 16:00:00 +0530 MD Danish Anwar wrote:
>> +/**
>> + * Config state machine variables. See IEEE Std 802.1Q-2018 8.6.8.4
>> + */
>
> Please use correct kdoc format with all members documented or not use
> the /** marker.
>

Sure. I will update the documentation with correct kdoc format.

>> +struct tas_config_list {
>> + /* New list is copied at this time */
>> + u64 config_change_time;
>> + /* config change error counter, incremented if
>> + * admin->BaseTime < current time and TAS_enabled is true
>> + */
>> + u32 config_change_error_counter;
>> + /* True if list update is pending */
>> + u8 config_pending;
>> + /* Set to true when application trigger updating of admin list
>> + * to active list, cleared when configChangeTime is updated
>> + */
>> + u8 config_change;
>> +};

--
Thanks and Regards,
Danish

\
 
 \ /
  Last update: 2023-10-05 18:12    [W:0.103 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site