Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 5 Oct 2023 16:51:57 +0100 | Subject | Re: [PATCH v4 1/2] bpftool: Align output skeleton ELF code | From | Quentin Monnet <> |
| |
On 04/10/2023 23:23, Ian Rogers wrote: > libbpf accesses the ELF data requiring at least 8 byte alignment, > however, the data is generated into a C string that doesn't guarantee > alignment. Fix this by assigning to an aligned char array. Use sizeof > on the array, less one for the \0 terminator, rather than generating a > constant. > > Fixes: a6cc6b34b93e ("bpftool: Provide a helper method for accessing skeleton's embedded ELF data") > Signed-off-by: Ian Rogers <irogers@google.com> > Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Acked-by: Quentin Monnet <quentin@isovalent.com>
Thanks
| ![\](/images/icornerr.gif) |