Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v3] net: phy: broadcom: add support for BCM5221 phy | From | Paolo Abeni <> | Date | Thu, 05 Oct 2023 12:34:00 +0200 |
| |
On Thu, 2023-09-28 at 20:59 +0200, Giulio Benetti wrote: > From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com> > > This patch adds the BCM5221 PHY support by reusing brcm_fet_*() > callbacks and adding quirks for BCM5221 when needed. > > Cc: Jim Reinhart <jimr@tekvox.com> > Cc: James Autry <jautry@tekvox.com> > Cc: Matthew Maron <matthewm@tekvox.com> > Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > V1->V2: > Suggested by Andrew Lunn: > * handle mdix_ctrl adding bcm5221_config_aneg() and bcm5221_read_status() > * reorder PHY_ID_BCM5241 in broadcom_tbl[] > Suggested by Russell King: > * add comment on phy_read(..., MII_BRCM_FET_INTREG) > * lock mdio bus when in shadow mode > Suggested by Florian Fainelli: > * reuse brcm_fet_*() callbacks checking for phy_id == PHY_ID_BCM5221 > > V2->V3: > * rebase on master branch
LGTM, but waiting an extra bit for explicit ack from Florian.
Cheers,
Paolo
| ![\](/images/icornerr.gif) |