lkml.org 
[lkml]   [2023]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [ANNOUNCE] v6.6-rc4-rt7
On 2023-10-05 15:38:06 [+0200], Pierre Gondois wrote:
> Hello Sebastian,
Hi Pierre,

> The following happened once [1]. In pl011_console_write() from:
> commit da042bbb7a3f ("printk: Update the printk series.")
> &uap->port seems to be released, but various paths don't seem
> to acquire the lock,

Thank you for the report.
The following cures it:

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 96da994e5af06..c6c2d3e46a8ec 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -2335,7 +2335,7 @@ pl011_console_write(struct console *co, const char *s, unsigned int count)
if (uap->port.sysrq || oops_in_progress)
locked = uart_port_trylock_irqsave(&uap->port, &flags);
else
- uart_port_trylock_irqsave(&uap->port, &flags);
+ uart_port_lock_irqsave(&uap->port, &flags);

/*
* First save the CR then disable the interrupts
> Regards,
> Pierre

Sebastian

\
 
 \ /
  Last update: 2023-10-05 17:50    [W:0.074 / U:2.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site