Messages in this thread | | | From | <> | Subject | Re: [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config | Date | Thu, 5 Oct 2023 11:02:43 +0000 |
| |
On Wed, 2023-10-04 at 11:00 -0700, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote: > > + netif_warn(adapter, drv, adapter->netdev, > > + "rx timestamp = %d is not > > supported\n", > > + rx_filter); > > I addition to Jake's comments please also drop this warning. > Hi Jakub, Thanks for the comments. Sure, will drop the warning or add it as debug message.
> > + return -EINVAL; > > And make sure this is the correct return code. > I thought -ERANGE was more appropriate here, but I could be wrong.
Will check and add the appropriate return code in v2 patch.
| |