Messages in this thread | | | Date | Thu, 5 Oct 2023 10:41:46 +0200 | Subject | Re: [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple supplies | From | Krzysztof Kozlowski <> |
| |
On 05/10/2023 09:46, Naresh Solanki wrote: > Hi Rob, > > > On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@kernel.org> wrote: >> >> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote: >>> Add support for multiple supplies. >> >> Why? > 1. Driver is already capable of that using platform data. Hence added > support to read DT property & initialize the same for multiple > supplies instead of being limited to one.
I am not sure that's a valid reason. Bindings focus on the hardware. We do not describe here driver capabilities.
> 2. This is particularly useful in cases wherein 2 or more regulators > are coupled together, for example in a PCIe connector having 3.3V & > 12V.
Commit message should explain this. Each commit, when not obvious, should say why you are doing things.
Best regards, Krzysztof
| |