Messages in this thread | | | Date | Wed, 4 Oct 2023 08:40:46 +0200 | Subject | Re: [PATCH v6 07/11] firmware: imx: add driver for NXP EdgeLock Enclave | From | Krzysztof Kozlowski <> |
| |
On 27/09/2023 19:53, Pankaj Gupta wrote: > The Edgelock Enclave , is the secure enclave embedded in the SoC > to support the features like HSM, SHE & V2X, using message based > communication channel. > > ELE FW communicates on a dedicated MU with application core where > kernel is running. It exists on specific i.MX processors. e.g. > i.MX8ULP, i.MX93. > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
Where is the user-space tool? Please include it in the commit msg. We talked about this already.
> --- > Documentation/ABI/testing/se-cdev | 41 + > drivers/firmware/imx/Kconfig | 12 +
...
> + > + ret = ele_mu_request_channel(dev, &priv->rx_chan, > + &priv->ele_mb_cl, info->mbox_rx_name); > + if (ret) { > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Failed to request rx channel\n"); > + > + goto exit; > + } > + > + priv->ctxs = devm_kzalloc(dev, sizeof(dev_ctx) * priv->max_dev_ctx, > + GFP_KERNEL); > + > + if (!priv->ctxs) { > + ret = -ENOMEM; > + dev_err(dev, "Fail allocate mem for private dev-ctxs.\n");
So you ignored the feedback... I assume you ignored it all, so:
NAK
Please go back and implement the feedback.
Best regards, Krzysztof
| |