Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH] nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by | Date | Wed, 4 Oct 2023 06:33:37 +0000 |
| |
On 10/3/23 16:25, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct nvmet_fc_tgt_queue. > > Cc: James Smart <james.smart@broadcom.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagi@grimberg.me> > Cc: Chaitanya Kulkarni <kch@nvidia.com> > Cc: linux-nvme@lists.infradead.org > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook <keescook@chromium.org> > --- >
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
| |