Messages in this thread | | | Date | Wed, 4 Oct 2023 15:20:01 +0200 | Subject | Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the absence of ACPI enumeration | From | Krzysztof Kozlowski <> |
| |
On 04/10/2023 15:09, Andy Shevchenko wrote: > On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On 26/09/2023 21:08, Andy Shevchenko wrote: > > ... > >>> +MODULE_ALIAS("platform:denverton-pinctrl"); >> >> Why do you need the alias? It's the same as ID table. You most likely >> miss MODULE_DEVICE_TABLE() or your table is just wrong. > > This is cargo cult from pinctrl-broxton.c. If we want to fix, we need > to fix both. > Care to send patches?
I don't understand how some other file affects this. Why do you exactly need module alias here? Which use-case does not work without it (after adding proper MODULE_DEVICE_TABLE())?
Best regards, Krzysztof
| |