Messages in this thread | | | Date | Wed, 4 Oct 2023 08:34:58 +0200 | Subject | Re: [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode | From | Thorsten Leemhuis <> |
| |
On 04.10.23 08:19, Greg Kroah-Hartman wrote: > On Tue, Oct 03, 2023 at 07:57:24PM -0500, Jeffery Miller wrote: >> Make `elantech_setup_ps2` set a compatible fast_reconnect pointer >> when its ps2 mode is used. >> >> When an SMBus connection is attempted and fails `psmouse_smbus_init` >> sets fast_reconnect to `psmouse_smbus_reconnect`. >> `psmouse_smbus_reconnect` expects `psmouse->private` to be >> `struct psmouse_smbus_dev` but `elantech_setup_ps2` replaces >> it with its private data. This was causing an issue on resume >> since psmouse_smbus_reconnect was being called while in ps2, not SMBus >> mode. >> >> This was uncovered by commit 92e24e0e57f7 ("Input: psmouse - add delay when >> deactivating for SMBus mode") >> >> Closes: >> Link:https://lore.kernel.org/all/ca0109fa-c64b-43c1-a651-75b294d750a1@leemhuis.info/ >> Reported-by: Thorsten Leemhuis <linux@leemhuis.info> >> >> Signed-off-by: Jeffery Miller <jefferymiller@google.com> >> --- >> >> The other callbacks set in psmouse_smbus_init are already replaced. >> Should fast_reconnect be set to `elantech_reconnect` instead? > > What commit id does this fix?
Good point, yes, it also needs this:
Fixes: 92e24e0e57f72e ("Input: psmouse - add delay when deactivating for SMBus mode")
> Should it also have a cc: stable tag?
Not that I can see, as that commit was merged for 6.6 and not backported (no idea why Jeffery CCed the stable list, maybe I'm missing something)
Ciao, Thorsten
| |