Messages in this thread | | | Date | Wed, 4 Oct 2023 10:50:54 +0200 | Subject | Re: [PATCH] idpf: fix building without IPv4 | From | Alexander Lobakin <> |
| |
From: Tony Nguyen <anthony.l.nguyen@intel.com> Date: Mon, 25 Sep 2023 10:05:03 -0700
> > On 9/25/2023 8:58 AM, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> The newly added offload code fails to link when IPv4 networking is >> disabled: >> >> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: in >> function `idpf_vport_splitq_napi_poll': >> idpf_txrx.c:(.text+0x7a20): undefined reference to `tcp_gro_complete' >> >> Add complile-time checks for both CONFIG_INET (ipv4) and CONFIG_IPV6 >> in order to drop the corresponding code when the features are >> unavailable. >> This should also help produce slightly better output for IPv4-only >> kernel builds, if anyone still uses those. > > Hi Arnd, > > Also, a pending patch for this [1], however, this does look a bit more
I agree Arnd's version is more efficient, the other question is why my patch has been hanging in your tree for 2 weeks, although I asked to take it directly to fix automated builds ASAP xD
> efficient. Adding Olek as he's author on the other patch. > > netdev maintainers, > > If this is the version that does get picked up, did you want to take it > directly to close out the compile issues?
[...]
Thanks, Olek
| |