lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC 1/1] KVM: x86: add param to update master clock periodically
From
Date
On Tue, 2023-10-03 at 17:07 -0700, Sean Christopherson wrote:
>
> The issue is that the timekeeping code doesn't provide a notification mechanism
> to *just* get updates for things like suspend/reume.  We could maybe do something
> in KVM like unregister the notifier if the TSC is constant, and manually refresh
> on suspend/resume.  But that's pretty gross too, and I'd definitely be concerned
> that we missed something.

Or *in* the existing notifier, just do the maths (correctly!) and don't
update KVM's raw_clock data if the only thing that's really changed is
the passage of time?

On the whole, it's better if your other patch works to avoid the drift
in the first place. I'll test it...
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2023-10-04 10:06    [W:0.192 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site