lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH net-next] net: phy: aquantia: add firmware load support
    On Sat, 30 Sep 2023 12:39:44 +0200 Robert Marko wrote:
    > + ret = of_property_read_string(dev->of_node, "firmware-name",
    > + &fw_name);

    Perhaps a well established weirdness of the embedded world but why read
    the fw name from OF?! You can identify what PHY it is and decide the
    file name based on that. And also put that fw name in MODULE_FIRMWARE()
    so that initramfs can be built with appropriate file in place :S

    > + ret = request_firmware(&fw, fw_name, dev);

    \
     
     \ /
      Last update: 2023-10-05 01:29    [W:5.054 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site