lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: renesas: rzn1: enable PINMUX
Hi Ralph,

ralph.siemsen@linaro.org wrote on Wed, 4 Oct 2023 16:00:08 -0400:

> Enable pin muxing (eg. programmable function), so that the RZN1 GPIO
> pins will be configured as specified by the pinmux in the DTS.
>
> This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS,
> however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02
> since the rzn1 driver does not call any of the generic pinmux functions.
>
> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>

You probably need to point at this commit with a Fixes and possibly Cc
this to stable. Also you should use proper formatting for the commit
(12 digits sha then the text inside ("...")).

With this added:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---
> drivers/pinctrl/renesas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/renesas/Kconfig b/drivers/pinctrl/renesas/Kconfig
> index 77730dc548ed..0ad8e14ccc52 100644
> --- a/drivers/pinctrl/renesas/Kconfig
> +++ b/drivers/pinctrl/renesas/Kconfig
> @@ -234,6 +234,7 @@ config PINCTRL_RZN1
> bool "pin control support for RZ/N1"
> depends on OF
> depends on ARCH_RZN1 || COMPILE_TEST
> + select PINMUX
> select GENERIC_PINCONF
> help
> This selects pinctrl driver for Renesas RZ/N1 devices.


Thanks,
Miquèl

\
 
 \ /
  Last update: 2023-10-05 00:25    [W:0.067 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site