lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] spi: bcm2835: add a sentinel at the end of the lookup array
    Date
    From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

    GPIOLIB expects the array of lookup entries to be terminated with an
    empty member. We need to increase the size of the variable length array
    in the lookup table by 1.

    Fixes: 21f252cd29f0 ("spi: bcm2835: reduce the abuse of the GPIO API")
    Reported-by: Hans de Goede <hdegoede@redhat.com>
    Closes: https://lore.kernel.org/lkml/29764d46-8d3d-9794-bbde-d7928a91cbb5@redhat.com/
    Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
    ---
    drivers/spi/spi-bcm2835.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
    index c9078fee3662..e709887eb2a9 100644
    --- a/drivers/spi/spi-bcm2835.c
    +++ b/drivers/spi/spi-bcm2835.c
    @@ -1299,7 +1299,7 @@ static int bcm2835_spi_setup(struct spi_device *spi)
    * More on the problem that it addresses:
    * https://www.spinics.net/lists/linux-gpio/msg36218.html
    */
    - lookup = kzalloc(struct_size(lookup, table, 1), GFP_KERNEL);
    + lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL);
    if (!lookup) {
    ret = -ENOMEM;
    goto err_cleanup;
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-10-04 20:39    [W:4.531 / U:1.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site