lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 05/25] x86/fpu/xstate: Remove kernel dynamic xfeatures from kernel default_features
From
Date
On Thu, 2023-09-14 at 09:22 -0700, Dave Hansen wrote:
> On 9/13/23 23:33, Yang Weijiang wrote:
> > --- a/arch/x86/kernel/fpu/xstate.c
> > +++ b/arch/x86/kernel/fpu/xstate.c
> > @@ -845,6 +845,7 @@ void __init fpu__init_system_xstate(unsigned int legacy_size)
> > /* Clean out dynamic features from default */
> > fpu_kernel_cfg.default_features = fpu_kernel_cfg.max_features;
> > fpu_kernel_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC;
> > + fpu_kernel_cfg.default_features &= ~fpu_kernel_dynamic_xfeatures;
>
> I'd much rather that this be a closer analog to XFEATURE_MASK_USER_DYNAMIC.
>
> Please define a XFEATURE_MASK_KERNEL_DYNAMIC value and use it here.
> Don't use a dynamically generated one.
>

I also think so.

Best regards,
Maxim Levitsky




\
 
 \ /
  Last update: 2023-10-31 18:46    [W:1.008 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site