lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] kbuild: Add inline-account tool
    On Mon, Oct 23, 2023 at 8:23 AM Andi Kleen <ak@linux.intel.com> wrote:
    >
    > > How to use this tool?
    > >
    > > I did not get any output?
    >
    > Hmm, perhaps you need CONFIG_DEBUG_INFO=y ?


    Please print a hint suggesting CONFIG_DEBUG_INFO
    if "objdump --source" does not output the
    source-mixed disassembly.


    >
    > > I do not think this patch is mature enough
    > > regarding the coding style.
    > >
    > > Please polish the code.
    >
    > Don't follow. It's standard python code style, and the
    > other python scripts in scripts/ use the same.


    I hoped somebody would have provided some code reviews,
    but it looks like it did not get people's interest.


    See other scripts and check how the code is structured in functions.

    I do not want to see a patch like
    94a03e1d22e8dc75ddec159b2efadd4c6354503a

    So, the script should be written in good quality
    from day 1.


    Also, PEP-8 is worth reading to learn good coding style
    if you have not checked.




    --
    Best Regards
    Masahiro Yamada

    \
     
     \ /
      Last update: 2023-10-31 18:42    [W:7.228 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site