Messages in this thread | | | Subject | Re: [PATCH v2] selftests/net: synchronize udpgso_bench rx and tx | From | Paolo Abeni <> | Date | Tue, 31 Oct 2023 15:49:45 +0100 |
| |
On Tue, 2023-10-31 at 09:26 -0400, Lucas Karpinski wrote: > > Since you wrote the same function verbatim in 3 different files, I > > think it would be better place it in separate, new, net_helper.sh > > file > > and include such file from the various callers. Possibly > > additionally > > rename the function as wait_local_udp_port_listen. > > > Thanks, I'll move it over. I think it would be best though to leave > udp out of the name and to just pass the protocol as an argument.
Indeed. I suggested the other option just to keep it the simpler, but if you have time and will, please go ahead!
Cheers,
Paolo
| |